When electrons move down energy levels, are they gaining or losing energy?

When they move closer to the nucleus, they are said to be losing energy; however, they most likely move up through the shells and gain energy. Also, they are unstable in the new shells, so they usually return to their original shells and expel the extra energy through photons or other means.

Full change in the electric plus system