Shops and business sometimes employ professional sign writers. Do we still need professional sign writers or is this a dead/dying art?

it depends

Explanation:

Signwriters design, manufacture and install signs, including advertising signs for shops, businesses and public facilities as well ... Traditional signwriters use methods closely related to those of their forebears in this craft and do not ... Designs are often created by hand on the drawing board and later combined with CAD